On Thu, 31 May 2001 00:49:31 -0800, Chad Austin aegis@aegisknight.org wrote:
Hi,
First, what's standard etiquette for using a mailing list? Do I respond to both the person and the list, or just the list, or what?
I would suggest, only reply to the list.
It actually works? what modification did you make to the code, especially huffman.c ?
[...]
Of course, there were several other minor changes. One of these days I'll build a patch and submit it to Rob.
For now, use anonymous CVS:
CVSROOT=:pserver:anonymous@pyrallis.aegisknight.org:d:/cvsroot
cvs login Password: guest
cvs co acoustique
just made a patch, if anyone is interested to look at them: http://www.asamnet.de/~finkm/mad-patch.diff
In my opinion, there are some changes that are unnecessary, for example the introduction of the symbol MAD_EXTERN_C. since *.c files are always compiled using extern "C" linkage (at least in VC++), that is unneeded I think. Just list your exports in a separate .def file.
Another thing are constructs like #ifdef _MSC_VER /* VC++ */ #define MAD_INLINE __inline #else /* assume gcc */ #define MAD_INLINE inline #endif
just provide a custom config.h, define HAVE_CONFIG_H and all things will be good :-) I could provide one for win32 I anyone cares
The type casts on the functions are ok I think, it makes the VC++ not warn so often, maybe Rob considers it to build it into libmad
bye Michael